hardening: gate plugins, add hook timeouts, and sanitize metadata#1
Open
mczabca-boop wants to merge 1 commit intosteven1522:feature/plugin-systemfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a stacked PR on top of TinyAGI#127 (
feature/plugin-system) that hardens the plugin runtime without changing plugin API shape.Changes:
TINYCLAW_PLUGINS_ENABLED=1required to load pluginsTINYCLAW_PLUGIN_HOOK_TIMEOUT_MS(default1500)TINYCLAW_PLUGIN_ACTIVATE_TIMEOUT_MS(default3000)parseMode === "MarkdownV2"Plugin Securitysection)Why
#127introduces dynamic plugin loading from local filesystem.This PR reduces risk and blast radius by:
Testing
npm run -s build:mainpassesPlugins disabled..., normal startup/shutdownNo plugins directory found, normal startup/shutdownactivate()activate timed out ...)Dependency / Stacking
steven1522:feature/plugin-systemmain.